Looks good to me! ----- Original Message ----- From: prasanta.sadhuk...@oracle.com To: philip.r...@oracle.com, 2d-dev@openjdk.java.net Sent: Wednesday, August 31, 2016 3:17:27 AM GMT -08:00 US/Canada Pacific Subject: Re: [OpenJDK 2D-Dev] RFR: 8144015: [PIT] failures of text layout font tests
Looks ok to me. Regards Prasanta On 8/26/2016 2:40 AM, Phil Race wrote: > > Webrev: http://cr.openjdk.java.net/~prr/8144015/ > > This RFR encompasses changes that are sufficiently related > to keep them all together and they deserve testing as a whole. > Multiple test failures are resolved. A list is below. > > Notable highlights > ExtendedTextSourceLabel.createCharinfo() can now handle > cases where the glyph count is less than the char count. > This was not just a problem in 9 (harfbuzz) but has been > observed on 8 too (8041480 in the list below). > The fundamental change is to abandon the idea of > updating in place which added complexity and was > never going to work if you had too few glyphs .. > > HBShaper.c > - Fixed that kerning was always enabled > - Simplified - and corrected - the code that stored the resulting data > - Stopped using throwing an exception as a way to expand storage > - Cleaned up JNI usage > > Tests have been added/updated/open sourced as necessary. > > JPRT passed these changes. > > > Bugs fixed by this change : > https://bugs.openjdk.java.net/browse/JDK-8144015 > 8144015: [PIT] failures of text layout font tests > > ** https://bugs.openjdk.java.net/browse/JDK-8144023 > 8144023: [PIT] failure of text measurements in > javax/swing/text/html/parser/Parser/6836089/bug6836089.java > > ** https://bugs.openjdk.java.net/browse/JDK-8145542 > 8145542: The case failed automatically and thrown > java.lang.ArrayIndexOutOfBoundsException exception > > ** https://bugs.openjdk.java.net/browse/JDK-8151725 > 8151725: [macosx] ArrayIndexOOB exception when displaying Devanagari > text in JEditorPane > > ** https://bugs.openjdk.java.net/browse/JDK-8144240 > 8144240: [macosx][PIT] AIOOB in > closed/javax/swing/text/GlyphPainter2/6427244/bug6427244.java > > https://bugs.openjdk.java.net/browse/JDK-8152680 > 8152680: Regression in GlyphVector.getGlyphCharIndex behaviour > > ** https://bugs.openjdk.java.net/browse/JDK-8158924 > 8158924: Incorrect i18n text document layout > > ** https://bugs.openjdk.java.net/browse/JDK-8041480 > 8041480: ArrayIndexOutOfBoundsException when JTable contains certain > string > > -phil.
