On 9/26/16, 12:50 PM, Clemens Eisserer wrote:
Thanks a lot for the feedback.
The fix seems fine .. is there a possibility to have a regression test?
Perhaps based on the code in the bug ?
Please find an automated regression test at:
http://93.83.133.214/8162591/HugeGradientTest.java
OK .. should be part of the patch tho'
-phil.
Should we also check the transform?
I guess we already do this in some way, but is it enough?
I was not 100% sure myself. As the Paint classes are stateless, there
is some overhead involved in checking the transformation in
isPaintValid (allocation of an additional AffineTransformation by
calling MultipleGradientPaint.getTransform() + additional call to
invert() as there is no isInvertible() method). I guess it doesn't
matter at all - considering how much else is going on when creating a
new GradientPaint.
Please find the updated webrev at: http://93.83.133.214/8162591/webrev.02/
Best regards, Clemens
