Re: [OpenJDK 2D-Dev] RFR: 8165981: Consider making some classes in javax.imageio.plugins.tiff final

[Phil Race]

Ok to the two you are making final.

>  Question is whether TIFFDirectory might be made final as well.

com.sun.imageio.plugins.tiff.TIFFIFD extends TIFFDirectory so that
is more than a case of marking it final.
Therefore it at least depends on whether you think that internal subclass
really needs to be a subclass ?

-phil.

On 10/03/2016 11:53 AM, Brian Burkhalter wrote:

A trivial change, code-wise:

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java

@@ -261,7 +261,7 @@
  * @see TIFFDirectory
  * @see TIFFTag
  */
-public class TIFFField implements Cloneable {
+public final class TIFFField implements Cloneable {

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFImageReadParam.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFImageReadParam.java

@@ -48,7 +48,7 @@
  *
  * @since 9
  */
-public class TIFFImageReadParam extends ImageReadParam {
+public final class TIFFImageReadParam extends ImageReadParam {

Question is whether TIFFDirectory might be made final as well.

Thanks,

Brian