Can I get a 2nd reviewer on this one ?

-phil.

On 10/20/16, 3:52 AM, Sergey Bylokhov wrote:
Looks fine.

On 20.10.16 2:35, Philip Race wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8168364
webrev : http://cr.openjdk.java.net/~prr/8168364/

NSPrintInfo is an Attribute so it can presumably be stuffed in an
AttributeSet.
Apart from being inaccessible to apps and unused it is not a good idea.
It was perhaps once used to (re-?)initialise fNSPrintInfo .. and that
needs to
be synchronized it seems. I fixed the one other unsynchronised use of that
as well as deleting the unused code.

-phil.


Reply via email to