Re: [OpenJDK 2D-Dev] [9] RFR JDK-8168498: ExifGPSTagSet and ExifTIFFTagSet should use string literals for String constants

[Phil Race]

+1

-phil

On 10/24/2016 12:49 PM, Brian Burkhalter wrote:

Updating to simply use a double-quoted string instead of a concatenation of chars.

Thanks,

Brian

On Oct 21, 2016, at 12:18 PM, Brian Burkhalter <brian.burkhal...@oracle.com <mailto:brian.burkhal...@oracle.com>> wrote:

Please review this trivial change at your convenience:

Issue:https://bugs.openjdk.java.net/browse/JDK-8168498
Patch:[1]

[1] diff

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifGPSTagSet.java

@@ -55,9 +55,7 @@
      *
      * @see #TAG_GPS_VERSION_ID
      */
-    public static final String GPS_VERSION_2_2 =
-        new String(new byte[] { '2', '2', '0', '0' },
-        StandardCharsets.US_ASCII);
+    public static final String GPS_VERSION_2_2 = "2200";

--- a/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java +++ b/src/java.desktop/share/classes/javax/imageio/plugins/tiff/ExifTIFFTagSet.java

@@ -71,9 +71,7 @@
      *
      * @see #TAG_EXIF_VERSION
      */
-    public static final String EXIF_VERSION_2_1 =
-        new String(new byte[] { '0', '2', '1', '0' },
-        StandardCharsets.US_ASCII);
+    public static final String EXIF_VERSION_2_1 = "0210";


@@ -82,9 +80,7 @@
      *
      * @see #TAG_EXIF_VERSION
      */
-    public static final String EXIF_VERSION_2_2 =
-        new String(new byte[] { '0', '2', '2', '0' },
-        StandardCharsets.US_ASCII);
+    public static final String EXIF_VERSION_2_2 = "0220";