Hi Sergey, Good catch, I added the memsets to the two other files, too. Sorrry it took that long, I just wanted to make sure it causes no upsets on solaris or BSD, I had to fix our build first.
New webrev: http://cr.openjdk.java.net/~goetz/wr16/8170798-java2d_sound/webrev.03/ This ran through all our testing successfully. I'll push it Monday to client if there are no objections. Best regards, Goetz. > -----Original Message----- > From: Sergey Bylokhov [mailto:sergey.bylok...@oracle.com] > Sent: Mittwoch, 14. Dezember 2016 19:29 > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com> > Cc: Phil Race <philip.r...@oracle.com>; 2d-dev <2d-dev@openjdk.java.net>; > sound-...@openjdk.java.net > Subject: Re: [OpenJDK 2D-Dev] RFR(M): 8170798: Fix minor issues in java2d and > sound coding. > > Hello. > > >> So it seems like the elements at indices from controlCount to 10 may not > >> be initialised but I don't see how this would be a problem since > >> PORT_NewCompoundControl > >> has no hardwired "10" .. it just uses controlCount. > >> In any case this would seem better addressed by the same kind of memset > >> after stack allocation that you proposed for the jpeg case. > > Fixed. (I thought it's cheaper to initialize only the rest, and more simple > > for the C-compiler to remove where useless.) > > It seems that some other implementations of PORT_NewCompoundControl can > have the same issue, like in : > PLATFORM_API_BsdOS_ALSA_Ports.c and PLATFORM_API_SolarisOS_Ports.c. > Should we apply the same memset there to make them in sync?
