On 01/06/2017 12:33 AM, Prasanta Sadhukhan wrote:
Hi Phil,
Looks good to me . One thing is that, the check forplatformID !=
MAC_PLATFORM_ID
shouldn't we do the same in initAllNames()?
No, I don't think so. initAllNames() is specifically looking for all the
Windows localised names
and in this change the idea is just to find an English name on Mac ..
not to look for others.
Also, in the test, I guess we do not need
33 import java.io.BufferedInputStream;
35 import java.io.FileInputStream;
36 import java.io.InputStream;
37
and copyright should be 2017.
Well, I wrote it in 2016 :-) .. I only posted it in 2017.
Anyway I will make those changes before I push.
-phil.
Regards
Prasanta
On 1/5/2017 5:25 AM, Philip Race wrote:
Bug : https://bugs.openjdk.java.net/browse/JDK-6232267
Webrev : http://cr.openjdk.java.net/~prr/6232267/
Fonts such as "Menlo" on OS X have no Microsoft names
(see https://www.microsoft.com/typography/otspec/name.htm)
so historically we rejected these.
Now that we support OS X, this is more of an issue, and
it is possible to run into a case where we fail to parse these fonts
when they go through the Font.createFont() path, even on OS X.
This adds that basic support for parsing Apple names so that
we load the font. This support already exists on JavaFX.
-phil.
