Thank you very much, Phil!
Looking for the second +1 from someone else.
Dmitry
> On 21 Jan 2017, at 22:39, Philip Race <[email protected]> wrote:
>
> +1
>
> -phil
>
> On 1/21/17, 11:05 AM, Dmitry Markov wrote:
>>
>> Hi Phil,
>>
>> I agree ‘othervm’ is not necessary here. That is ‘copy-paste’ error.
>> Also I updated the part related to the file deletion based on your
>> suggestion.
>> Please find new webrev here:
>> http://cr.openjdk.java.net/~dmarkov/8163889/webrev.02/
>> <http://cr.openjdk.java.net/%7Edmarkov/8163889/webrev.02/>
>>
>> Thanks,
>> Dmitry
>>> On 21 Jan 2017, at 00:24, Philip Race <[email protected]
>>> <mailto:[email protected]>> wrote:
>>>
>>> Hi Dmitry,
>>> > 29 * @run main/othervm PrintCrashTest
>>> why othervm ?
>>>
>>> I don't think that is strictly necessary just because you are using
>>> deleteOnExit.
>>> And FWIW I think the test could "more promptly" delete the file anyway
>>> after print returns.
>>>
>>> -phil.
>>>
>>>
>>> On 1/20/17, 9:36 AM, Dmitry Markov wrote:
>>>>
>>>> Hi Phil, Prasanta,
>>>>
>>>> I have updated the fix as you suggested, (i.e. added the regression test).
>>>> The new webrev is located at
>>>> http://cr.openjdk.java.net/~dmarkov/8163889/webrev.01/
>>>> <http://cr.openjdk.java.net/%7Edmarkov/8163889/webrev.01/>
>>>> Could you review the new version, please?
>>>>
>>>> Thanks,
>>>> Dmitry
>>>>> On 20 Jan 2017, at 19:50, Phil Race <[email protected]>
>>>>> <mailto:[email protected]> wrote:
>>>>>
>>>>> I haven't looked at the fix (yet) but I definitely agree that a manual
>>>>> regression test
>>>>> for this is better than none. What else should we do ? Just not test
>>>>> printing ?
>>>>>
>>>>> In my view which I've expressed to SQE for a really long time, if you
>>>>> aren't testing with
>>>>> printers installed you aren't testing the whole platform. Whilst it may
>>>>> be convenient
>>>>> that tests (silently) don't complain when there are no printers, it is a
>>>>> slippery slope ..
>>>>>
>>>>> -phil.
>>>>>
>>>>> On 01/20/2017 04:04 AM, Prasanta Sadhukhan wrote:
>>>>>> It is possible to create manual regression test for this problem. Also
>>>>>> the test will require some additional set up steps such as printer
>>>>>> installation and so on. It seems to me that is overhead for person who
>>>>>> runs it. However if you insist on test creation, I will add it.
>>
