Re: [OpenJDK 2D-Dev] [9] RFR JDK-8152561: Is it allowed to have zero value for count in TIFFField.createArrayForType() for the rationals

[Philip Race]

} else if((dataType == TIFFTag.TIFF_RATIONAL

I know that someone (ahem Brian ;-)) has a lot of "if(" code in here
but please make any new ones "if ("

Other than that, +1

-phil.



On 1/24/17, 1:08 PM, Brian Burkhalter wrote:

Hi Jay,

I think line 910 of TIFFField needs to state “and count != 1”. Also the copyright year should now be 2017.

OK to make these changes without another webrev: +1.

Thanks,

Brian

On Jan 18, 2017, at 1:03 AM, Jayathirth D V <jayathirth....@oracle.com <mailto:jayathirth....@oracle.com>> wrote:

Please find updated webrev for review :

http://cr.openjdk.java.net/~jdv/8152561/webrev.01/ <http://cr.openjdk.java.net/%7Ejdv/8152561/webrev.01/>