I am not sure that the test is any less valid .. it has recorded
specific results of layout with ICU
and runs harfbuzz comparing it to the archived results.
But even as a manual test it will be a no-op without the right font
environment.
But I'll leave this up to Steven to decide as he provided us with these
tests.
One other issue with this test is that it uses JAXP classes which are
slated to be removed ..
Perhaps jtreg will still provide a way to access these classes on the
classpath without
test modifications ???
-phil.
On 10/12/2017 02:22 PM, Sergey Bylokhov wrote:
Looks fine.
I guess we should update TestLayoutVsICU.java test which was added as
part of harfbuzz integration. I assumed that it should compares
behavior against icu, but it seems it is never executed.
On 12/10/2017 10:45, Steven R. Loomis wrote:
approve
On Wed, Oct 11, 2017 at 9:59 AM, Phil Race <philip.r...@oracle.com
<mailto:philip.r...@oracle.com>> wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8183978
<https://bugs.openjdk.java.net/browse/JDK-8183978>
Webrev: http://cr.openjdk.java.net/~prr/8183978/
<http://cr.openjdk.java.net/~prr/8183978/>
This fix removes the obsolete ICU opentype layout code from JDK 10.
I've built this on all platforms (including open+closed builds).
-phil.
