Hi Thomas, I'm a "contributor", but not a "committer", so not on that list, didn't even know that list existed! I was sort of assuming since it was a trivial change, and the request was for a review, i'd chip in...! Thanks Andrew
Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: "Thomas Stüfe" <thomas.stu...@gmail.com> To: Adam Farley8 <adam.far...@uk.ibm.com>, Andrew Leonard <andrew_m_leon...@uk.ibm.com> Cc: 2d-dev <2d-dev@openjdk.java.net> Date: 21/03/2018 15:42 Subject: Re: [OpenJDK 2D-Dev] RFR: Bug Pending: Build fails to compile jchuff.c Hi, @Andrew Leonard: Sorry, I cannot find your name in http://openjdk.java.net/census#jdk. Are you a jdk contributor/reviewer, and if yes, what is your user name? @openjdk 2d folks: I also need to know: does the 2d project have any special rules about who can push or can I just push (I am jdk reviewer, census name stuefe)? Also, if A.Leonard is not a valid reviewer, could I still push this under the "trivial" rule? The change is quite trivial :) Best, Thomas On Wed, Mar 21, 2018 at 4:17 PM, Adam Farley8 <adam.far...@uk.ibm.com> wrote: cc'ing Tom directly in case this fell into a digest. > I've reviewed it. The change looks good, it's a good programming practice while loop now :-) > Cheers > Andrew > > Andrew Leonard > Java Runtimes Development > IBM Hursley > IBM United Kingdom Ltd > Phone internal: 245913, external: 01962 815913 > internet email: andrew_m_leon...@uk.ibm.com > > > Hi Tom, > > > > Much obliged. :) > > > > Any volunteers to be the 2nd reviewer? > > > > Best Regards > > > > Adam Farley > > > > > Hi Adam, > > > > > > this patch looks good. I can sponsor this for you if noone else steps up, but we need a second reviewer, preferably one from the 2d project. > > > > > > Best Regards, Thomas > > > > > > On Wed, Mar 21, 2018 at 12:41 PM, Adam Farley8 < adam.far...@uk.ibm.com> wrote: > > > Hi All, > > > > > > If committers really don't want this code, we could always try fixing the code that the warning > > > is complaining about. > > > > > > ------------------------------ Change --------------------------------------- > > > diff --git a/src/java.desktop/share/native/libjavajpeg/jchuff.c b/src/java.desktop/share/native/libjavajpeg/jchuff.c > > > --- a/src/java.desktop/share/native/libjavajpeg/jchuff.c > > > +++ b/src/java.desktop/share/native/libjavajpeg/jchuff.c > > > @@ -805,7 +805,7 @@ > > > for (i = MAX_CLEN; i > 16; i--) { > > > while (bits[i] > 0) { > > > j = i - 2; /* find length of new prefix to be used */ > > > - while (bits[j] == 0) > > > + while ((bits[j] == 0) && (j > 0)) > > > j--; > > > > > > bits[i] -= 2; /* remove two symbols */ > > > ------------------------------ End of Change --------------------------------------- > > > > > > Again, it's a small, simple change that fixes a build break on two platforms. > > > > > > Either fix will solve this problem. > > > > > > Best Regards > > > > > > Adam Farley > > > > > > > Hi All, > > > > > > > > I ask for a committer to add one word to make/lib/Awt2dLibraries.gmk to solve a build break. > > > > > > > > We need to go to line 495 and add array-bounds into the list of disabled warnings. > > > > > > > > So this: > > > > > > > > DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value, \ > > > > > > > > becomes this: > > > > > > > > DISABLED_WARNINGS_gcc := clobbered implicit-fallthrough shift-negative-value array-bounds, \ > > > > > > > > This fixes a build-breaking problem which occurs if you don't disable > > > > errors-as-warnings on zLinux or Linux for ppcle. > > > > > > > > Best Regards > > > > > > > > Adam Farley > > > > > > > > P.S. For further background, see this: > > > > http://mail.openjdk.java.net/pipermail/2d-dev/2018-March/008958.html > > > > > > Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
