+1
On 20/03/2018 19:42, Prahalad Kumar Narayanan wrote:
Hello Phil
Good day to you.
Thank you for the explanation. I understand your point now.
The code changes look good.
Thank you
Have a good day
Prahalad N.
----- Original Message -----
From: Phil Race
Sent: Wednesday, March 21, 2018 12:14 AM
To: Prahalad Kumar Narayanan; 2d-dev
Subject: Re: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is
selected via system property
I typed
+ (!(FontUtilities.useT2K && !FontUtilities.useLegacy) ?
when I actually meant
+ ((!FontUtilities.useT2K && !FontUtilities.useLegacy) ?
ie the first "!" was supposed to be inside ..
I decided to add a debugging option to make it easier to tell what you'd got
and then further decided to add code that falls back to freetype if you
asked for T2K but it isn't there.
http://cr.openjdk.java.net/~prr/8199789.1
I've tested it with openjdk + oracle JDK builds.
I think it'll do for now until T2K is removed.
-phil.
On 03/20/2018 02:30 AM, Prahalad Kumar Narayanan wrote:
Hello Phil
Good day to you.
I imported your patch and checked the resulting build.
Warnings showed up as expected with use of "t2k" or "legacy" in the VM option
-Dsun.java2d.font.scaler.
However, I'm unable to interpret this line and its intended outcome.
It also adds a new value for sun.java2d.font.scaler of "legacy" which means
"t2k" but as it was used in by default.
In my observation with logs, setting VM option to
"t2k" instantiates T2KFontScaler and
"legacy" instantiates FreetypeFontScaler.
If this is the intended behavior, the code changes work as expected.
Thank you
Have a good day
Prahalad N.
-----Original Message-----
From: Phil Race
Sent: Tuesday, March 20, 2018 1:09 AM
To: 2d-dev
Subject: [OpenJDK 2D-Dev] RFR 8199789: Emit a warning message when t2k is
selected via system property
Bug: https://bugs.openjdk.java.net/browse/JDK-8199789
Webrev : http://cr.openjdk.java.net/~prr/8199789/
https://bugs.openjdk.java.net/browse/JDK-8193017 made freetype the default font
rasteriser for all JDK builds.
We plan to remove t2k completely including references to it from open sources,
before JDK 11 GA's
But for now it is still there for debugging but to make it clear this small fix
makes a warning get printed if you try to use it.
It also adds a new value for sun.java2d.font.scaler of "legacy" which means
"t2k" but as it was used in by default.
The subtle issue is that "t2k" disables using GDI for LCD text.
"legacy" gets you exactly what JDK did by default in 6u10 -> JDK 10 inclusive.
So it may be more useful for a debugging comparison flag.
-phil.
--
Best regards, Sergey.
