On 3/23/18, 11:56 AM, Sergey Bylokhov wrote:
Hi, Prahalad.
A few small comments about the test:
- Is it possible to test all installed ImageWriterSpi? It seems that the test itself is not a JPEG plugin specific?

None of the other plugins support thumbnails so they will all return 0 regardless.
So I think that aspect of the test is OK


 - You will need to dispose the jpgWriter even in case of exception.

Probably should fix that.

Everything else seems fine.

-phil.

On 23/03/2018 01:10, Prahalad Kumar Narayanan wrote:
Kindly review the changes at your convenience
Link: http://cr.openjdk.java.net/~pnarayanan/4954348/webrev.00

Thank you
Have a good day

Prahalad N.



Reply via email to