Hi Matthias, Looks good.
Best Regards, Thomas On Tue, May 22, 2018 at 8:33 AM, Baesken, Matthias <matthias.baes...@sap.com> wrote: > Hi Phil, thanks for looking into it. > > > > Can I get a second review ? > > > > Best regards, Matthias > > > > From: Phil Race [mailto:philip.r...@oracle.com] > Sent: Freitag, 18. Mai 2018 17:37 > To: Baesken, Matthias <matthias.baes...@sap.com>; 2d-dev > <2d-dev@openjdk.java.net> > Subject: Re: [OpenJDK 2D-Dev] RFR [XS] - 8203355 : MITSHM define guarding > missing > > > > Looks fine. > > -phil. > > On 05/17/2018 11:49 PM, Baesken, Matthias wrote: > > Please review this minor change that adds a missing #ifdef MITSHM > > Compile time guarding to X11SurfaceData.c > > > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8203355.0/ > > > > https://bugs.openjdk.java.net/browse/JDK-8203355 > > > > > > Usually one would not run into any problems because of the > double-guarding by “HEADLESS”, but in case that MITSHM in not defined > (we do this for a special build here locally) > > we run into issues . So the added ifdef check cleans up this minor issue > . > > > > Thanks and regards, Matthias > > > >
