Hi, I pushed this patch and asked for jdk11u backport: I added label and comment to the jbs bug.
Is it enough ? Or should I send an email to jdk updates .... Laurent Le dim. 23 sept. 2018 à 09:21, Sergey Bylokhov <sergey.bylok...@oracle.com> a écrit : > Looks fine. > > On 18/09/2018 00:22, Laurent Bourgès wrote: > > Hi, > > > > Please could a second reviewer have a look ? > > Phil approved 2 weeks ago. > > I would like this bug done asap. > > > > I will propose for review the javafx patch (almost the same fix) in a > > moment. > > > > Cheers, > > Laurent > > > > Le mar. 11 sept. 2018 à 08:55, Laurent Bourgès > > <bourges.laur...@gmail.com <mailto:bourges.laur...@gmail.com>> a écrit : > > > > Hi, > > Can I have a second review, please ? > > > > I would like to make a jdk11 updates fix request asap... > > > > Laurent > > > > Le jeu. 6 sept. 2018 à 09:31, Laurent Bourgès > > <bourges.laur...@gmail.com <mailto:bourges.laur...@gmail.com>> a > écrit : > > > > Phil, > > Thanks for your review. > > > > Le jeu. 6 sept. 2018 à 01:39, Philip Race > > <philip.r...@oracle.com <mailto:philip.r...@oracle.com>> a > écrit : > > > > This looks good to me. > > I've run all our automated tests + done some manual testing > > as well as building on all platforms and reviewing the > > source changes. > > > > > > Do you have more closed-source tests that could be opened in > > OpenJDK ? > > > > > > > PS: What is the process to ask for backport to JDK11 > > updates ? > > > > If you think this important enough to backport, then this is > > the process : > > > > http://openjdk.java.net/projects/jdk-updates/approval.html > > > > > > I fixed these bugs as I was contacted on the Marlin mailing list > > by an end user testing the migration of its Map viewer app from > > jdk8 to OpenJDK11. > > > > I made this patch as small as possible that is compatible with > > OpenJDK 11/12 and is well tested: low risk. > > For 12, I will propose a more important patch later to upgrade > > to Marlin 0.9.3 > > > > As JDK11 is LTS and this bug is a regression (P3 ?) since 10, I > > think it is worth fixing it in 11 too. > > > > Any other opinion ? > > > > PS: I will fix OpenJFX 11/12 soon > > > > Cheers, > > Laurent > > > > > -- > Best regards, Sergey. >