Looks good.
There's one inconsistency though:
java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterDevice.java
72 return new GraphicsConfiguration[] {config};
In all the other implementations of getConfigurations() method, there's
no space between brackets and braces.
Shall the copyright year be updated to 2019?
Regards,
Alexey
On 12/12/2018 20:55, Sergey Bylokhov wrote:
Yes, I have build/tested it manually on win/lin/mac platforms, and
using mach5 for all supported platforms.
On 11/12/2018 19:23, Philip Race wrote:
Looks OK. Please confirm it builds on all platforms + headful +
headless tests pass on all platforms ..
-phil.
On 11/30/18, 6:21 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk 12.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214076
Webrev: http://cr.openjdk.java.net/~serb/8214076/webrev.01
While I am working on the:
https://bugs.openjdk.java.net/browse/JDK-8076313
I have started to unify the code between the platforms, and found
that the fix became bigger than the small cleanup.
So I decided to extract it to this separate CR.
Change description:
- Unused java/native methods were removed
- Name of the variables are unified:
1. GConfig will refer GDevice using "device" variable
2. GDevice will refer GConfig using "config" variable
- @Override is used in all classes
- Empty javadoc spec was removed
- Most classes were marked as "final" to prove that it is not
necessary to
update "some other" platform specific subclasses
