Sorry .. missed it.
One more thing about the test, I am not sure why you need to use
sun.font.FontDesignMetrics directly ?
Isn't it enough to create a BufferedImage and get an appropriate
FRC and FM by setting the properties on the graphics for that ?
-phil.
On 2/19/19, 10:48 AM, Martin Balao wrote:
Hi Phil,
Are we good to go with Webrev.01?
Thanks,
Martin.-
On 2/14/19 3:47 PM, Martin Balao wrote:
Hi Phil,
Thanks for your feedback.
I proposed the font in the test case because it's licensed under GNU
Affero General Public License, Version 3 (AGPL) with an exemption [2].
My understanding was that we were able to ship it. Anyways, I removed
the font and use system installed fonts. On newer Linux distributions,
Z003 font should be available anyways.
Comment added explaining that bold value comes from freetype 2.6 and is
valid at least up to 2.9.1.
I was not sure if applying the OBLIQUE_MODIFIER changes as part of this
ticket. Done.
Line lengths adjusted to not exceed 80 chars.
freetypeScaler.c copyright date updated.
Webrev 01:
* http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.01/
* http://cr.openjdk.java.net/~mbalao/webrevs/8218854/8218854.webrev.01.zip
Are we good to go?
Kind regards,
Martin.-
--
[1] - https://github.com/URWTypeFoundry/Core_35/blob/master/COPYING
[2] - https://github.com/URWTypeFoundry/Core_35/blob/master/LICENSE
