On 20/02/2019 01:38, Sergey Bylokhov wrote:
Hi, Andrey.

I found only one questionable place in the fix:
==================
     /**
      * Returns an object created with id=key. If the object is not of
-     * type type, this will throw an exception.
+     * that type, this will throw an exception.
      */
     private Object lookup(String key, Class<?> type) throws SAXException {
         Object value;
==================
The first "type" is a synonym to "class" and the second "type" is the name of the method parameter.

Instead of first "type" you can use "an instance of <code>type</code>" or "class".

I agree, “If the object is not an instance of <code>type</code> class…” is much clearer.

--
Regards,
Alexey

On 31/01/2019 14:28, Andrey Turbanov wrote:
Hello.
I would like to contribute small patch to fix repeated words typos.

Andrey Turbanov


<SNIP>

Reply via email to