Hi Volker, thanks for doing this fix. It looks good to me.
I'd personally prefer if the #if switches would be in the form of #if defined(__solaris__) #elif defined(_AIX) #endif e.g. lines 441, 659 and 660. But other than that, I have no points. Best regards Christoph > -----Original Message----- > From: 2d-dev <[email protected]> On Behalf Of Volker > Simonis > Sent: Mittwoch, 13. März 2019 11:09 > To: 2d-dev <[email protected]> > Subject: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and > Xrender functionality > > Hi, > > can I please have a review for the following change which fixes > Xinerama and Xrender support on AIX: > > http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528/ > https://bugs.openjdk.java.net/browse/JDK-8220528 > > The change basically fixes the way how the corresponding libraries > (libXext and libXrender) get loaded on AIX and does some cleanups with > regards to the various platform macros. I've also added some debug > tracing to the Xrender initialization code similar to the Xinerama > initialization. > > Thank you and best regards, > Volker
