On 03/04/2019 09:35, Alexey Ivanov wrote:
We can make minRefreshTime equal to 2 minutes but leave the default refresh time of 4 minutes. Does it sound good? This way the time of waiting for two refresh cycles would be reduced to 4 minutes only>
What do you think about this suggestion?
If you agree, I'll submit a new CR to update both the implementation and the
test.
But why do you need a separate CR? The "sun.java2d.print.minRefreshTime" is a
java property, we can set it in this test to 1 minute or so, and suggest the user to wait
2 minutes, no?
If not, then I would rather leave the test and its instructions as they are in
webrev.1.
Are there any other comments?
On 29/03/2019 08:28, Alexey Ivanov wrote:
Please take a look at the updated webrev where I've removed @ignore tag from
the test:
http://cr.openjdk.java.net/~aivanov/8221263/webrev.1/
On 29/03/2019 01:09, Philip Race wrote:
Are you looking for a reason other than that the implementation
is set to refresh the printer list every 4 minutes ?
Yes, remote printer list is refreshed every 4 minutes on Windows.
The reason why I added step 6 is that the user has no way of knowing when the
refresh occurred. The refresh could happen just before the printer is added.
Waiting for another refresh is to prevent false failures. If the list isn't
updated in two refresh cycles, likely it won't be updated. In this case, the
user will click Fail.
Regards,
Alexey
-phil.
On 3/28/19, 5:52 PM, Sergey Bylokhov wrote:
Hi, Alexey.
I think it is ok to drop @ignore tag, but I wonder why did you add the step6 to
the instruction.
197 + "updated.\n"
198 + "Step 6: If the list is not updated, wait for another
"
199 + "4 minutes, and then click Refresh again.\n"
<SNIP>
--
Best regards, Sergey.
