Looks fine.
On 24/03/2019 12:18, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows. It's because the
functions in splashscreen.dll are exported with decorated names now, yet
they're looked up by the undecorated names.
The easiest way to reproduce the problem is to run SwingSet2:
java -jar SwingSet2.jar
Fix:
The fix removes JNICALL (__stdcall) declarations from splash screen functions.
Thus the functions are exported undecorated.
I've run SplashScreen jtreg tests, all tests pass.
This is a follow-up fix to
https://bugs.openjdk.java.net/browse/JDK-8201226
https://bugs.openjdk.java.net/browse/JDK-8202476
which re-enabled 32 bit Windows post removal of mapfiles / compiler options.
Thank you in advance.
Regards,
Alexey
--
Best regards, Sergey.
