Hi Phil, Changes are fine. I think script name of Telugu should be “telugu” and not “telegu”.
Thanks, Jay > On 25-Apr-2019, at 9:23 PM, Phil Race <philip.r...@oracle.com> wrote: > > Any takers ? Jay ? Also adding i18n-dev. > > -phil. > > On 4/20/19 4:29 PM, Philip Race wrote: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8208179 >> Webrev: http://cr.openjdk.java.net/~prr/8208179/index.html >> >> The original complaint is missing devanagari in logical fonts in Oracle JDK >> 11. >> I realised in looking at this that we are also missing Thai. >> The reason is that Lucida Sans was removed and there are no windows fonts >> configured to replace these. >> In fixing this we can also add support for other Indic scripts and Khmer + >> Mongolian too >> as Windows 7 and later all contain suitable UI fonts. >> >> One wrinkle is that we will be more likely to trip over a small bug whereby >> if we have registered one font in a family due to it being mentioned in a >> logical >> font and that font can be used to synthesis another style of that font, we >> don't >> go to check to see if there is a system font of the exact style. >> FontFamily.getFont(String name, int style) has a comment warning of this >> possibility. >> This was observed that Mangal hid Mangal Bold for example, and >> inconsistently if >> you used the Mangal Bold font directly it was not hidden and would be used. >> So the fix adds a call to an existing method which will resolve all fonts in >> that family first. >> >> A test is provided which verifies the scripts are now supported by the >> logical fonts on Windows. >> >> -phil. >> >> >
