I don't know how timely it is to cleanup this code. Anyway, you've
removed global awtJNI_GetFontData() function but left its external
declaration in open/src/java.desktop/unix/native/common/awt/awt_p.h:
http://hg.openjdk.java.net/jdk/client/file/f680bedc0dcb/src/java.desktop/unix/native/common/awt/awt_p.h#l122
Since native code was modified can you provide the prove that the change
doesn't brake the build?
--Semyon
On 5/18/19 3:10 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for JDK 13.
Bug: https://bugs.openjdk.java.net/browse/JDK-8224171
Fix: http://cr.openjdk.java.net/~serb/8224171/webrev.00
This change is the part of my effort to clean up the native
initialization code in awt/2d. Initially, I have dropped the native
code inside initIds() which was unused(JDK-8223766[1]). Now I tried to
check is the code inside initIDs() is used for some meaningful purpose.
I found that XFontPeer.initIds() uses XFontPeer.xfsname field which is
always null, so in this fix, I have dropped the field itself, the
initIds(), the methods which depend on this field, and methods which
calls methods which depends on this field, etc. Next step will be
clean up the native code for the Fonts itself, there is some unused
code as well.
Note that this field was unused since 2009[2]
[1] https://bugs.openjdk.java.net/browse/JDK-8223766
[2] http://hg.openjdk.java.net/jdk/client/rev/a79da6a9d184
