Hi Phil, Unfortunately I'm not a reviewer on 12 so I won't be able to OK for you, but the patch looks good to me. We had found a similar issue with Freetype and also came to the same conclusion that we should have the rendering mode to version 35 I think.
I agree "better" is subjective, but I think this patch should be in. Cheers, Mario On Tue, Jun 11, 2019 at 2:41 PM Philip Race <philip.r...@oracle.com> wrote: > > Hi, > > I am still looking for a code review on this - needed today ! > > -phil. > > On 6/5/19, 11:43 AM, Phil Race wrote: > > bug: https://bugs.openjdk.java.net/browse/JDK-8217731 > > webrev: http://cr.openjdk.java.net/~prr/8217731/ > > > > This is intended to "help" but cannot completely cure, with > > some of the rendering differences in JDK11 vs JDK 8. > > In a typical Swing app on Windows using LCD rendering > > it manifests as subtle adjustments in the spacing between glyphs. > > There isn't an easy regression test for this, and it is subjective > > as to how bad it was before and how much this improves it, > > even if you were to accept that 8 is "better" .. and not just > > different .. > > > > -phil. -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898
