In such cases I like more than to be told "it would apply cleanly" but
also to see
that you actually prepared the webrev against 13. This is more certain
and ensures that when the fix is approved you don't accidentally push it
to the wrong repo. You have to go clone 13 and apply the patch there
anyway ...
-phil.
On 7/11/19, 5:44 AM, Anton Litvinov wrote:
Hello Phil,
Thank you for review and the important remark about the need to work
with "jdk/jdk13" stabilization repository, I forgot about this feature
of post RDP 1 phase. Today I checked the fix against "jdk/jdk13"
repository and confirm that it resolves this bug for JDK 13.
Will wait for feedback or approval from any other second code reviewer.
Thank you,
Anton
On 10/07/2019 19:55, Phil Race wrote:
Anton,
This looks fine except that it needs to be prepared against 13, and
then pushed there, not 14.
And it will get forwarded synced from 13 to 14. That is the RDP
process ..
-phil.
On 7/10/19 5:00 AM, Anton Litvinov wrote:
Hello,
Could you please review the following fix for the bug. The fix is
backing out of the fix for the bug JDK-8214579 which caused this JCK
test failure. If this fix is accepted, then a new separate bug for
readdressing the bug reported in JDK-8214579 will be filed.
Bug: https://bugs.openjdk.java.net/browse/JDK-8227392
Webrev: http://cr.openjdk.java.net/~alitvinov/8227392/jdk14/webrev.00
Changeset of JDK-8214579:
http://hg.openjdk.java.net/jdk/client/rev/c53905e7dc57
Thank you,
Anton
