Looks good.
+1
-- Kevin
On 8/6/2019 12:28 AM, Laurent Bourgès wrote:
Ping:
Could someone do a second review ?
Laurent
Le ven. 2 août 2019 à 17:01, Laurent Bourgès
<bourges.laur...@gmail.com <mailto:bourges.laur...@gmail.com>> a écrit :
Thanks Philip,
I am waiting for another approval,
Cheers,
Laurent
Le ven. 2 août 2019 à 00:13, Philip Race <philip.r...@oracle.com
<mailto:philip.r...@oracle.com>> a écrit :
+1 from me. Looks the same as the FX fix modulo some moving
things around.
-phil.
On 7/29/19, 12:56 AM, Laurent Bourgès wrote:
> Hi,
>
> Please review this bug fix for the Marlin renderer
(introduced in
> JDK11.0.2):
> JBS: https://bugs.openjdk.java.net/browse/JDK-8228711
> webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin-8228711.0/
>
<http://cr.openjdk.java.net/%7Elbourges/marlin/marlin-8228711.0/>
>
> This patch is very close to MarlinFX patch integrated last
week in
> OpenJFX 14, see https://bugs.openjdk.java.net/browse/JDK-8226789
>
> Changes:
> - Stroker: fixed closePath() to preserve last position and
its outcode
> - TransformingPathConsumer2D: fixed
PathClipFilter.closePath() to
> preserve last position and its outcode
> - Dasher: better precision handling (comparison float value
with epsilon)
> - ClipShapeTest: use preliminary curve subdivision (length >
50px) to
> avoid false positives on long stroked curves (quad / cubic)
+ lowered
> thresholds
>
> Cheers,
> Laurent
--
--
Laurent Bourgès
