+1. Thanks, Jay
> On 10-Sep-2019, at 3:18 AM, Phil Race <philip.r...@oracle.com> wrote: > > Approved. > > -phil. > > On 9/6/19 2:15 PM, Laurent Bourgès wrote: >> Hi, >> >> Please review this bug fix for the Marlin renderer (present in Pisces code >> since JDK 6?): >> JBS: https://bugs.openjdk.java.net/browse/JDK-8230728 >> <https://bugs.openjdk.java.net/browse/JDK-8230728> >> webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/ >> <http://cr.openjdk.java.net/~lbourges/marlin/marlin-8230728.0/> >> >> This patch fixes a NaN handling in userSpaceLineWidth() when the affine >> transform determinant is negative (flip bit is ON) >> >> Changes: >> - MarlinRenderingEngine: use abs(at.getDeterminant()) to ensure positive >> value before using sqrt >> - FlipBitTest: new jtreg test reproducing the original problem drawing a >> thin ellipse with a flipped transform >> >> Cheers, >> Laurent >
