Hi Phil,
thanks for your review. I changed this usage of Scanner by intention. Scanner implements Closeable/AutoCloseable and hence I think it's preferable to close the scanner after usage. That's what the try-with-resources construct will do. It'll take care that the underlying filestream gets promptly closed after the scanner is done. Are you ok with it? I'd push it to the client repo then. Best regards Christoph From: Philip Race <[email protected]> Sent: Freitag, 20. September 2019 23:28 To: Langer, Christoph <[email protected]> Cc: Baesken, Matthias <[email protected]>; [email protected] Subject: Re: [OpenJDK 2D-Dev] <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file Looks fine to me, although I am not sure why you edited this 289 private String getVersionString(File f) { 290 try (Scanner sc = new Scanner(f)) { 291 return sc.findInLine("(\\d)+((\\.)(\\d)+)*<file://d)+((/.)(/d)+)*>"); 292 } catch (Exception e) { 293 } 294 return null; 295 } Were you planning to add logging on the exception but changed your mind ? -phil. On 9/20/19, 2:15 PM, Langer, Christoph wrote: Hi, friendly reminder: Anybody else wants to review this? Thanks Christoph From: Baesken, Matthias <[email protected]><mailto:[email protected]> Sent: Montag, 9. September 2019 08:52 To: Langer, Christoph <[email protected]><mailto:[email protected]>; [email protected]<mailto:[email protected]> Subject: RE: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file Hi Christoph, thanks for the review and further cleanup ! > Would be good if somebody from 2D could review this, though. I agree ! Best regards, Matthias From: Langer, Christoph <[email protected]<mailto:[email protected]>> Sent: Freitag, 6. September 2019 15:42 To: Baesken, Matthias <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> Subject: RE: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file Hi Matthias, I checked your RFR and it looks ok. I have some minor suggestions and spotted some further room for cleanup in FcFontConfiguration.java. I've taken your code, added my modifications and prepared a new webrev. http://cr.openjdk.java.net/~clanger/webrevs/8227441.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8227441.0/> Would be good if somebody from 2D could review this, though. Thanks Christoph From: 2d-dev <[email protected]<mailto:[email protected]>> On Behalf Of Baesken, Matthias Sent: Dienstag, 16. Juli 2019 17:09 To: [email protected]<mailto:[email protected]> Subject: [CAUTION] Re: [OpenJDK 2D-Dev] <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file Ping , any comments on this one ? Thanks, Matthias From: Baesken, Matthias Sent: Mittwoch, 10. Juli 2019 08:49 To: [email protected]<mailto:[email protected]> Cc: Phil Race ([email protected]<mailto:[email protected]>) <[email protected]<mailto:[email protected]>> Subject: FW: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file >Before I, or anyone else, starts to look at or comment on this, >can you instead post to the correct list : 2d-dev. Sure! Best regards, Matthias From: Philip Race <[email protected]<mailto:[email protected]>> Sent: Dienstag, 9. Juli 2019 17:26 To: Baesken, Matthias <[email protected]<mailto:[email protected]>> Cc: [email protected]<mailto:[email protected]> Subject: Re: <AWT Dev> RFR [XS] : 8227441: Enhance logging when reading the fontconfig info file Hi, Before I, or anyone else, starts to look at or comment on this, can you instead post to the correct list : 2d-dev. -phil. On 7/9/19, 7:21 AM, Baesken, Matthias wrote: Hello, please review this small change that enhances logging a bit . When reading the fcinfo - file (fontconfig info file) we currently have very limited logging. This should be enhanced to get more info in case of errors , and to have at least some info in the log when -Dsun.java2d.debugfonts=true is set. Currently the logging writes a ton of info about lots of non-existant files , but misses the fcinfo file . Example output , we run here with -Dsun.java2d.debugfonts=true set : (with my added "successfully parsed the fontconfig file at ..." from the patch ) ... INFO: Creating standard Font Configuration Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.properties Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.4.12.14-25.25-default.bfc Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.Linux.4.properties Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.4.bfc Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.Linux.properties Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.Linux.bfc Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.4.12.14-25.25-default.properties Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.4.12.14-25.25-default.bfc Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.4.properties Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.4.bfc Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for text fontconfig file : /images/jdk/lib/fontconfig.properties Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findImpl INFO: Looking for binary fontconfig file : /images/jdk/lib/fontconfig.bfc Jul 09, 2019 3:36:59 PM sun.awt.FontConfiguration findFontConfigFile INFO: Did not find a fontconfig file. Jul 09, 2019 3:36:59 PM sun.font.FcFontConfiguration readFcInfo INFO: successfully parsed the fontconfig file at /myhomedir/user/.java/fonts/14.0.0.1-internal/fcinfo-1-thismachine-Linux-4.12.14-25.25-default-en-US.properties Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8227441 http://cr.openjdk.java.net/~mbaesken/webrevs/8227441.0/<http://cr.openjdk.java.net/%7Embaesken/webrevs/8227441.0/> Thanks, Matthias
