Hi Christoph, looks good to me .
I think the naming “xinerama_init_linux” is a bit misleading now , because the function is obviously not any more just for linux : 619 #if defined(__linux__) || defined(MACOSX) || defined(_AIX) 620 static void xinerama_init_linux() But this is out of scope of your downport change . Best regards, Matthias From: Langer, Christoph Sent: Dienstag, 24. September 2019 15:39 To: [email protected]<mailto:[email protected]> Cc: [email protected]<mailto:[email protected]> Subject: [11u] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality Hi, please help reviewing this backport of the fix for AIX Xinerama/Xrender basic functionality to JDK11 Updates. Bug: https://bugs.openjdk.java.net/browse/JDK-8220528 Original Change: http://hg.openjdk.java.net/jdk/jdk/rev/0223b7b8a1c5 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8220528.11u-dev.0/ The patch did not apply cleanly. I had to manually resolve the part around line 125 because the 11u version defines another function for Solaris that didn’t exist any more in the head version. Furthermore I needed to fix the #ifdef in line 1641 (new) to explicitly refer Solaris. Otherwise it would not build on AIX. Thanks Christoph
