Change looks good to me. And we have good amount of time to notice any pixel accuracy issues.
Thanks, Jay > On 12-Feb-2020, at 9:45 AM, Philip Race <philip.r...@oracle.com> wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8238942 > webrev: http://cr.openjdk.java.net/~prr/8238942/ > > As discussed in the bug, we are missing padding in the code that takes > an LCD glyph from freetype and caches it in the 2D glyph cache. > > This padding is used in subpixel positioning with fractional metrics on. > > I've run automated regression tests as well as doing extensive manual testing > and so far it looks fine. A specific regression test is hard because the > visual > artifacts manifest rarely and even so are not easy to test. > There should be plenty of time in JDK 15 for this to bake. > > -phil.
