I pushed with that small test change :
For the record: http://cr.openjdk.java.net/~prr/8240342.1/
-phil
On 4/1/20, 1:37 AM, Prasanta Sadhukhan wrote:
Looks good to me too. Only minor nit is, probably in testcase, we can
shift the BufferedImage creation code after the print service is found
Regards
Prasanta
On 01-Apr-20 7:37 AM, Sergey Bylokhov wrote:
On 3/31/20 5:42 pm, Philip Race wrote:
On 3/31/20 1:37 pm, Philip Race wrote:
The fix is in code used on Linux/Solaris and Windows only.
The Mac printing path is quite different and was not affected.
So are you misunderstanding my comment ?
Yep, reading your comment I assumed that the code change was
in code used on Linux/Solaris and Windows only and Mac printing
was not affected. However, the fix actually changes the behavior
on macOS as well and it is confirmed by the test, it is failed before
the fix and passed after.
+1.