Hi,
1) I missed this email, and as I am sure you know it was pushed a while back
2) SkippedException seems to be an EE thing, so not possible and
inappropriate from looking
at its ties to concurrency
3) It would defeat the purpose of the fix to throw any Exception in such
a case.
-phil.
On 3/18/20, 1:39 AM, Langer, Christoph wrote:
Hi Phil,
good to see this finally getting fixed.
Changes look good to me. I’m wondering, though, whether a
SkippedException should be thrown when there fonts are not found? On
the other hand, the test still probably always tests something, even
if certain fonts are missing.
Best regards
Christoph
*From:*2d-dev <2d-dev-boun...@openjdk.java.net> *On Behalf Of *Philip Race
*Sent:* Mittwoch, 18. März 2020 01:00
*To:* Sergey Bylokhov <sergey.bylok...@oracle.com>
*Cc:* 2d-dev <2d-dev@openjdk.java.net>
*Subject:* Re: [OpenJDK 2D-Dev] RFR: 8223935: PIT:
java/awt/font/WindowsIndicFonts.java fails on windows10
Done.
http://cr.openjdk.java.net/~prr/8223935.1/
<http://cr.openjdk.java.net/%7Eprr/8223935.1/>
Log looks like this :-
SysRootDir=C:\\Windows
found:C:\\Windows\\fonts\\mangal.ttf for Devanagari
found:C:\\Windows\\fonts\\vrinda.ttf for Bengali
found:C:\\Windows\\fonts\\raavi.ttf for Gurmukhi
found:C:\\Windows\\fonts\\shruti.ttf for Gujurati
found:C:\\Windows\\fonts\\kalinga.ttf for Oriya
found:C:\\Windows\\fonts\\latha.ttf for Tamil
found:C:\\Windows\\fonts\\gautami.ttf for Telugu
found:C:\\Windows\\fonts\\tunga.ttf for Kannada
found:C:\\Windows\\fonts\\kartika.ttf for Malayalam
found:C:\\Windows\\fonts\\iskpota.ttf for Sinhala
found:C:\\Windows\\fonts\\dokchamp.ttf for Thai
found:C:\\Windows\\fonts\\dokchamp.ttf for Lao
found:C:\\Windows\\fonts\\khmerui.ttf for Khmer
found:C:\\Windows\\fonts\\monbaiti.ttf for Mongolian
-phil.
On 3/17/20, 11:24 AM, Sergey Bylokhov wrote:
Hi, Phil.
Probably it is better to use "%SYSTEMROOT%\Fonts" instead of
"c:\\windows\\fonts"?
On 3/17/20 9:34 am, Philip Race wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8223935
Webrev: http://cr.openjdk.java.net/~prr/8223935/
<http://cr.openjdk.java.net/%7Eprr/8223935/>
WindowsIndicFonts has been failing randomly depending on
whether a test system has the Indic fonts installed.
This updates the test to not fail on systems which don't have
the expected
fonts installed in the typical default location.
-phil.
