On Fri, 25 Sep 2020 21:31:01 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 7179006: [macosx] Print-to-file doesn't work: printing to the default >> printer instead. > > src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 261: > >> 259: URI destURI = new URI(dest); >> 260: attributes.add(new Destination(destURI)); >> 261: destinationAttr = "" + destURI.getSchemeSpecificPart(); > > This destinationAttr in the RasterPrinterJob is usually assigned to: > destinationAttr = "" + new File(destination.getURI(). > getSchemeSpecificPart()); > Do we need to do the same here? I see that in WPrinterJob.java we do the same as I am doing here. I think the difference in RPJ may bethat we want to get a full path name which is what the new File did. Here macOS gives us a full path name already. So I don't think it is needed. It gave the required value for sure. ------------- PR: https://git.openjdk.java.net/jdk/pull/339
