> Please review a manual printing test failure where the instructions is not > matching the printing result > as the labels which are present in the test instruction frame is cut off in > printed result due to margin not being accounted for, > as the labels in the test instruction is fully left aligned starting from 0. > Fixed by adding some spaces before labels and > for other labels drawn through drawChars, modified to draw the labels from > coordinate 20 instead of 0 to allow labels being printed in the paper and not > get cutoff by margin. > Also, the Print instruction is brought to top and 1st label is brought to > bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to > account for top margin cutoff, brought it lower so that those labels does not > get cut off.
Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into JDK-8231231 - 8231231: The printing result is different from the case instruction ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/780/files - new: https://git.openjdk.java.net/jdk/pull/780/files/cc121c06..89d21206 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=780&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=780&range=00-01 Stats: 65759 lines in 901 files changed: 49411 ins; 12357 del; 3991 mod Patch: https://git.openjdk.java.net/jdk/pull/780.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/780/head:pull/780 PR: https://git.openjdk.java.net/jdk/pull/780
