On Wed, 21 Oct 2020 11:50:37 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> Please review a manual printing test failure where the instructions is not > matching the printing result > as the labels which are present in the test instruction frame is cut off in > printed result due to margin not being accounted for, > as the labels in the test instruction is fully left aligned starting from 0. > Fixed by adding some spaces before labels and > for other labels drawn through drawChars, modified to draw the labels from > coordinate 20 instead of 0 to allow labels being printed in the paper and not > get cutoff by margin. > Also, the Print instruction is brought to top and 1st label is brought to > bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to > account for top margin cutoff, brought it lower so that those labels does not > get cut off. This pull request has now been integrated. Changeset: 76796504 Author: Prasanta Sadhukhan <psadhuk...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/76796504 Stats: 5 lines in 2 files changed: 3 ins; 1 del; 1 mod 8231231: The printing result is different from the case instruction Reviewed-by: prr ------------- PR: https://git.openjdk.java.net/jdk/pull/780
