On Mon, 4 Jan 2021 08:09:31 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

> The java2d uses the primitives such as Blit loop for rendering differing 
> things. Currently, not all possible variants of primitives are implemented, 
> but it is possible to register some general loop that may produce the 
> primitives for some specific src/comp/dst.
> 
> But we have some inconsistent here:
>  - Some primitives register themselves as a general loop but always return 
> null in the makePrimitive() method
>  - Some primitives (which are not registered as general loops) return null or 
> throw an error in the makePrimitive() method
> 
> After the fix:
>  - The primitive will be registered as a general primitive only if it has a 
> meaningful makePrimitive method
>  - An attempt to call the makePrimitive for non registered general loop will 
> cause an error
> 
> mach5 is green

This pull request has now been integrated.

Changeset: 8a05d605
Author:    Sergey Bylokhov <s...@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/8a05d605
Stats:     260 lines in 22 files changed: 33 ins; 167 del; 60 mod

8259042: Inconsistent use of general primitives loops

Reviewed-by: prr

-------------

PR: https://git.openjdk.java.net/jdk/pull/1926

Reply via email to