On Sat, 8 May 2021 00:19:21 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Fix updated after first round of review. > > Alexander Zuev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Small fixes > Added testing for MultiResolutionImage > - Merge remote-tracking branch 'origin/master' into JDK-8182043 > - Update src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp > > Select one icon at a time. > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - Small fixes > Remived size parameter from makeIcon > Removed useVGAColors usage as irrelevant since it is ignored on all > supported platforms now > - 8182043: Access to Windows Large Icons > Fix updated based on the previous review. src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 267: > 265: * returned will be a multi-resolution icon image, > 266: * which will allow better scaling with different > 267: * scaling factors. “…which will allow better support for High DPI environments with different scaling factors.” — does it look better? “scaling with … scaling factors” doesn't sound good to me. ------------- PR: https://git.openjdk.java.net/jdk/pull/2875
