On Fri, 4 Jun 2021 11:14:46 GMT, Ajit Ghaisas <aghai...@openjdk.org> wrote:
> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2 > demo is run with uiScale=1.0. > > **Issue :** > SwingSet2 Demo - As reported in JBS description > J2DDemo - As reported in a comment on JBS > > **Root Cause :** > DrawPixel path is used only with uiScale=1.0. > MTLPrimitiveTypePoint is used to draw a pixel while encoding a render command. > As mentioned in the documentation - > https://developer.apple.com/documentation/metal/mtlprimitivetype/mtlprimitivetypepoint?language=objc > > "The vertex shader must provide [[point_size]], or the point size is > undefined." > > In our shader functions, we do not define this point size. It is harmless on > x86_64 based mac systems, but causes visual artifacts on M1 mac systems. > > **Solution :** > Explicitly define point size in shader functions that draw > MTLPrimitiveTypePoint. LGTM. Please add CI test run link in JBS, once it is completed. ------------- Marked as reviewed by jdv (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4356
