On Wed, 25 Aug 2021 05:41:03 GMT, Jayathirth D V <[email protected]> wrote:
>> Provide correct pipeline state for MTLPaint after reset
>
> src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m line 971:
>
>> 969: [encoder setRenderPipelineState:pipelineState];
>> 970: } else {
>> 971: // Fallback to valid pipeline state
>
> We should not call it a valid pipeline state. It is more of standard pipeline
> state with color 0 which we are using after reset.
>
> We are hitting default MTLPaint without any texture(which seems to be the
> main root cause for this issue- state management problem) and we end up not
> setting any pipeline state. Please reword this comment.
Also is it possible for us to just return at any earlier stage before we hit
setRenderPipelineState() without valid texture or color?
-------------
PR: https://git.openjdk.java.net/jdk/pull/5227