On Fri, 2017-05-05 at 15:10 +1000, William Brown wrote: > Hi all, > > I've been looking at https://pagure.io/389-ds-base/issue/49053 and > noticed issues with the functions here. It seems we export a set of > macros (like ldapu_err2string) that overload on a symbol name. Given the > current usage of these, I think we can purge the macros, and the > function table and just rely on our default implementations of these. > > The impact is that we would no longer support compilation on Windows. > Given that I don't think we have built on windows in maybe years, (our > remaining supported platforms are Linux and FreeBSD today), I would like > to purge this code and simplify this so that I can enable LTO. > > If I don't hear anything in the next few days, I'll go ahead and do this > anyway, >
Reading the code, I think we don't use the macros anyway, we use the symbols, so I'm going to write up a patch for this and we can discuss. -- Sincerely, William Brown Software Engineer Red Hat, Australia/Brisbane
signature.asc
Description: This is a digitally signed message part
_______________________________________________ 389-devel mailing list -- [email protected] To unsubscribe send an email to [email protected]
