On Fri, Oct 4, 2019 at 11:52 PM William Brown <[email protected]> wrote:

>
>
> > On 4 Oct 2019, at 17:50, Viktor Ashirov <[email protected]> wrote:
> >
> > Hi,
> >
> > On Fri, Oct 4, 2019 at 7:25 AM William Brown <[email protected]>
> wrote:
> > pytestmark = pytest.mark.tier1
> >
> > I saw this in a test and curious as to it's function? I'm sure it has
> one :)
> > See https://pagure.io/389-ds-base/issue/50353 for more context.
> > We use tier0 and tier1 for downstream component gating (similar to
> https://docs.fedoraproject.org/en-US/ci/gating/ but for RHEL).
> > I.e. 389-ds-base build should pass tier0 and tier1 tests 100% in order
> to land in the compose.
>
> That's a really good explanation, thanks!
>
> So when I'm adding new tests I should choose the tier based on those
> categories I expect?

Right. And if it's a test for a feature/bug fix that's not present in older
versions, please mark it as xfail based on the DS version (for example
https://pagure.io/389-ds-base/c/99f1131226b40e3d385cca66b2b35d5ea8cee582 ).
Thanks.

>
>
> > HTH
> >
> > --
> > Sincerely,
> >
> > William
> > _______________________________________________
> > 389-devel mailing list -- [email protected]
> > To unsubscribe send an email to [email protected]
> > Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> https://lists.fedoraproject.org/archives/list/[email protected]
> >
> >
> > --
> > Viktor
> > _______________________________________________
> > 389-devel mailing list -- [email protected]
> > To unsubscribe send an email to [email protected]
> > Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> > List Archives:
> https://lists.fedoraproject.org/archives/list/[email protected]
>
> —
> Sincerely,
>
> William Brown
>
> Senior Software Engineer, 389 Directory Server
> SUSE Labs
> _______________________________________________
> 389-devel mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
> Fedora Code of Conduct:
> https://docs.fedoraproject.org/en-US/project/code-of-conduct/
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/[email protected]
>


-- 
Viktor
_______________________________________________
389-devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to