Re: [9fans] sshserve.c

[Pietro Gagliardi]

On Apr 15, 2008, at 6:34 PM, [EMAIL PROTECTED] wrote:

Yup. usage() is calling itself with no termination condition - and
what's more, it is tail recursing. It should be

        void
        usage(void)
        {
                fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] 
client-ip-
address\n");
                exits("usage");
        }

to keep with the Plan 9 program. Enjoy!

When this QEMU-on-Leopard-freezes-randomly bug gets fixed, I can fix
it and any other dangers.

On Apr 15, 2008, at 6:05 PM, Kenji Arisawa wrote:

Hello,

In sshserve.c:

void
usage(void)
{
        fprint(2, "usage: sshserve [-A authlist] [-c cipherlist] client-ip-
address\n");
        usage();
}

This code can make endless loop. Right?

Kenji Arisawa

Submit a patch!
And don't top-post, damn it.  We aren't all MicroSavages here.


John

I'm on OS X, and again, I can't have QEMU crash just before rio starts!\