>> https://codereview.appspot.com/82660044/
>>
>> Please give a try and review this change to
>> get it submitted before the Go 1.4 release.
Sorry, David.
I made mistake to copy your patch file to Plan9
system (I've not set abaco yet).
I retried your above patch, and perfectly seamless results
which are included here.
Kenji
# Building C bootstrap tool.
cmd/dist
# Building compilers and Go bootstrap tool for host, plan9/386.
lib9
libbio
warning:
/usr/sys/src/go/src/libbio/bputrune.c:39[/usr/sys/src/go/src/libbio/bputrune.c:1450]
result of operation not used
libmach
warning:
/usr/sys/src/go/src/libmach/8db.c:207[/usr/sys/src/go/src/libmach/8db.c:2158]
unreachable code FUNC
warning:
/usr/sys/src/go/src/libmach/sym.c:374[/usr/sys/src/go/src/libmach/sym.c:2198]
useless or misleading comparison: UINT < 0
liblink
misc/pprof
cmd/objdump
cmd/prof
cmd/cc
warning:
/usr/sys/src/go/src/cmd/cc/y.tab.c:1785[/usr/sys/src/go/src/cmd/cc/y.tab.c:4593]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/cc/y.tab.c:1785[/usr/sys/src/go/src/cmd/cc/y.tab.c:4593]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/cc/y.tab.c:1791[/usr/sys/src/go/src/cmd/cc/y.tab.c:4599]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/cc/y.tab.c:1791[/usr/sys/src/go/src/cmd/cc/y.tab.c:4599]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/cc/y.tab.c:1788[/usr/sys/src/go/src/cmd/cc/y.tab.c:4596]
set and not used: yymsg
warning:
/usr/sys/src/go/src/cmd/cc/y.tab.c:1868[/usr/sys/src/go/src/cmd/cc/y.tab.c:4671]
set and not used: yytoken
warning:
/usr/sys/src/go/src/cmd/cc/y.tab.c:1952[/usr/sys/src/go/src/cmd/cc/y.tab.c:4751]
set and not used: yyptr
cmd/gc
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2049[/usr/sys/src/go/src/cmd/gc/y.tab.c:5497]
useless or misleading comparison: ULONG <= 0xffffffff
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2072[/usr/sys/src/go/src/cmd/gc/y.tab.c:5518]
useless or misleading comparison: ULONG <= 0xffffffff
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2080[/usr/sys/src/go/src/cmd/gc/y.tab.c:5526]
useless or misleading comparison: ULONG <= 0xffffffff
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2124[/usr/sys/src/go/src/cmd/gc/y.tab.c:5568]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2124[/usr/sys/src/go/src/cmd/gc/y.tab.c:5568]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2127[/usr/sys/src/go/src/cmd/gc/y.tab.c:5571]
set and not used: yymsg
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2234[/usr/sys/src/go/src/cmd/gc/y.tab.c:5673]
set and not used: yytoken
warning:
/usr/sys/src/go/src/cmd/gc/y.tab.c:2309[/usr/sys/src/go/src/cmd/gc/y.tab.c:5742]
set and not used: yyptr
cmd/8l
cmd/8a
warning:
/usr/sys/src/go/src/cmd/8a/y.tab.c:1376[/usr/sys/src/go/src/cmd/8a/y.tab.c:4282]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/8a/y.tab.c:1376[/usr/sys/src/go/src/cmd/8a/y.tab.c:4282]
result of operation not used
warning:
/usr/sys/src/go/src/cmd/8a/y.tab.c:1379[/usr/sys/src/go/src/cmd/8a/y.tab.c:4285]
set and not used: yymsg
warning:
/usr/sys/src/go/src/cmd/8a/y.tab.c:1567[/usr/sys/src/go/src/cmd/8a/y.tab.c:4461]
set and not used: yyptr
cmd/8c
cmd/8g
pkg/runtime
pkg/errors
pkg/sync/atomic
pkg/sync
pkg/io
pkg/unicode
pkg/unicode/utf8
pkg/unicode/utf16
pkg/bytes
pkg/math
pkg/strings
pkg/strconv
pkg/bufio
pkg/sort
pkg/container/heap
pkg/encoding/base64
pkg/syscall
pkg/time
pkg/os
pkg/reflect
pkg/fmt
pkg/encoding
pkg/encoding/json
pkg/flag
pkg/path/filepath
pkg/path
pkg/io/ioutil
pkg/log
pkg/regexp/syntax
pkg/regexp
pkg/go/token
pkg/go/scanner
pkg/go/ast
pkg/go/parser
pkg/os/exec
pkg/os/signal
pkg/net/url
pkg/text/template/parse
pkg/text/template
pkg/go/doc
pkg/go/build
cmd/go
# Building packages and commands for plan9/386.
runtime
errors
sync/atomic
sync
io
unicode
unicode/utf8
bytes
bufio
math
strconv
reflect
encoding/binary
syscall
time
os
fmt
debug/dwarf
debug/elf
strings
debug/gosym
debug/macho
debug/pe
sort
flag
log
cmd/addr2line
hash
crypto
crypto/md5
go/token
path/filepath
go/scanner
go/ast
io/ioutil
go/parser
text/tabwriter
go/printer
os/exec
cmd/cgo
go/format
path
cmd/fix
container/heap
encoding
encoding/base64
unicode/utf16
encoding/json
encoding/xml
regexp/syntax
regexp
net/url
text/template/parse
text/template
go/doc
go/build
compress/flate
hash/crc32
compress/gzip
container/list
crypto/subtle
crypto/cipher
crypto/aes
crypto/des
math/rand
math/big
crypto/elliptic
crypto/ecdsa
crypto/hmac
crypto/rand
crypto/rc4
crypto/rsa
crypto/sha1
crypto/sha256
crypto/dsa
encoding/asn1
crypto/x509/pkix
encoding/hex
encoding/pem
net
crypto/x509
crypto/tls
mime
net/textproto
mime/multipart
net/http
os/signal
cmd/go
runtime/pprof
cmd/gofmt
debug/goobj
cmd/link
debug/plan9obj
cmd/nm
cmd/pack
cmd/yacc
archive/tar
archive/zip
compress/bzip2
compress/lzw
hash/adler32
compress/zlib
container/ring
crypto/sha512
database/sql/driver
database/sql
encoding/ascii85
encoding/base32
encoding/csv
encoding/gob
expvar
hash/crc64
hash/fnv
html
html/template
image/color
image
image/color/palette
image/draw
image/gif
image/jpeg
image/png
index/suffixarray
log/syslog
math/cmplx
net/http/cgi
net/http/cookiejar
net/http/fcgi
net/http/httptest
net/http/httputil
net/http/pprof
net/mail
net/rpc
net/rpc/jsonrpc
net/smtp
os/user
runtime/debug
runtime/race
testing
testing/iotest
testing/quick
text/scanner
# Testing packages.
? cmd/addr2line [no test files]
? cmd/cgo [no test files]
ok cmd/fix 0.037s
ok cmd/go 0.042s
ok cmd/gofmt 0.105s
ok cmd/link 0.104s
? cmd/nm [no test files]
sys: trap: fault read addr=0xfffffffc pc=0x3a26
PC=0x3a26
goroutine 0 [idle]:
runtime.notesleep(0x1032e614)
/usr/sys/src/go/src/pkg/runtime/lock_sema.c:166 +0xd6
stopm()
/usr/sys/src/go/src/pkg/runtime/proc.c:935 +0xcd
findrunnable()
/usr/sys/src/go/src/pkg/runtime/proc.c:1243 +0x301
schedule()
/usr/sys/src/go/src/pkg/runtime/proc.c:1326 +0xeb
park0(0x103125a0)
/usr/sys/src/go/src/pkg/runtime/proc.c:1391 +0xe8
runtime.mcall(0x254a3)
/usr/sys/src/go/src/pkg/runtime/asm_386.s:190 +0x36
goroutine 16 [chan receive]:
testing.RunTests(0x1838e4, 0x1f6640, 0x5, 0x5, 0x30315201)
/usr/sys/src/go/src/pkg/testing/testing.go:504 +0x7c6
testing.Main(0x1838e4, 0x1f6640, 0x5, 0x5, 0x1feae0, ...)
/usr/sys/src/go/src/pkg/testing/testing.go:435 +0x8a
main.main()
/tmp/go-build125941623/cmd/pack/_test/_testmain.go:55 +0x82
goroutine 19 [finalizer wait]:
runtime.park(0x113d0, 0x1fa144, 0x1f95bc)
/usr/sys/src/go/src/pkg/runtime/proc.c:1350 +0x80
runtime.parkunlock(0x1fa144, 0x1f95bc)
/usr/sys/src/go/src/pkg/runtime/proc.c:1366 +0x3b
runfinq()
/usr/sys/src/go/src/pkg/runtime/mgc0.c:2578 +0xb0
runtime.goexit()
/usr/sys/src/go/src/pkg/runtime/proc.c:1426
goroutine 25 [runnable]:
syscall.startProcess(0x10357da3, 0x7, 0x10330810, 0x5, 0x6, ...)
/usr/sys/src/go/src/pkg/syscall/exec_plan9.go:561 +0x12c
syscall.StartProcess(0x10357da3, 0x7, 0x10330810, 0x5, 0x6, ...)
/usr/sys/src/go/src/pkg/syscall/exec_plan9.go:572 +0x72
os.startProcess(0x10357da3, 0x7, 0x10330810, 0x5, 0x6, ...)
/usr/sys/src/go/src/pkg/os/exec_plan9.go:33 +0x1e8
os.StartProcess(0x10357da3, 0x7, 0x10330810, 0x5, 0x6, ...)
/usr/sys/src/go/src/pkg/os/doc.go:24 +0x62
os/exec.(*Cmd).Start(0x10312d20, 0x0, 0x0)
/usr/sys/src/go/src/pkg/os/exec/exec.go:272 +0x5b4
os/exec.(*Cmd).Run(0x10312d20, 0x0, 0x0)
/usr/sys/src/go/src/pkg/os/exec/exec.go:234 +0x3a
os/exec.(*Cmd).CombinedOutput(0x10312d20, 0x0, 0x0, 0x0, 0x0, ...)
/usr/sys/src/go/src/pkg/os/exec/exec.go:364 +0x1ca
cmd/pack.func·005(0x103307e0, 0x5, 0x5, 0x0, 0x0)
/usr/sys/src/go/src/cmd/pack/pack_test.go:204 +0xf2
cmd/pack.TestHello(0x103663c0)
/usr/sys/src/go/src/cmd/pack/pack_test.go:221 +0x67e
testing.tRunner(0x103663c0, 0x1f6670)
/usr/sys/src/go/src/pkg/testing/testing.go:422 +0x87
created by testing.RunTests
/usr/sys/src/go/src/pkg/testing/testing.go:503 +0x78a
goroutine 28 [syscall]:
syscall.Syscall(0x103e9d18, 0x200, 0x0, 0x0, 0x0, ...)
/usr/sys/src/go/src/pkg/syscall/asm_plan9_386.s:19 +0x5
syscall.await(0x103e9d18, 0x200, 0x200, 0x104168cc, 0x0, ...)
/usr/sys/src/go/src/pkg/syscall/zsyscall_plan9_386.go:43 +0x70
syscall.Await(0x10327040, 0x0, 0x0)
/usr/sys/src/go/src/pkg/syscall/syscall_plan9.go:211 +0xc2
syscall.func·001()
/usr/sys/src/go/src/pkg/syscall/exec_plan9.go:556 +0x17a
created by syscall.startProcess
/usr/sys/src/go/src/pkg/syscall/exec_plan9.go:560 +0x103
ax 0x0
bx 0x1032e614
cx 0x1
dx 0x1
di 0x17
si 0x0
bp 0x1fa800
sp 0x103b9f5c
pc 0x3a26
flags 0x10202
cs 0x23
fs 0x1b
gs 0x1b
pack.test 1265: suicide: sys: trap: fault read addr=0xfffffffc pc=0x254b6
FAIL cmd/pack 0.082s
? cmd/yacc [no test files]
ok archive/tar 0.031s
ok archive/zip 0.601s
ok bufio 0.177s
ok bytes 0.220s
ok compress/bzip2 0.121s
ok compress/flate 1.467s
ok compress/gzip 0.421s
ok compress/lzw 0.730s
ok compress/zlib 1.741s
ok container/heap 0.021s
ok container/list 0.021s
ok container/ring 0.030s
? crypto [no test files]
ok crypto/aes 0.054s
ok crypto/cipher 0.032s
ok crypto/des 0.043s
ok crypto/dsa 0.073s
ok crypto/ecdsa 0.089s
ok crypto/elliptic 0.097s
ok crypto/hmac 0.020s
ok crypto/md5 0.088s
ok crypto/rand 0.078s
ok crypto/rc4 0.214s
ok crypto/rsa 0.879s
ok crypto/sha1 0.021s
ok crypto/sha256 0.020s
ok crypto/sha512 0.024s
ok crypto/subtle 0.032s
ok crypto/tls 5.207s
ok crypto/x509 6.681s
? crypto/x509/pkix [no test files]
ok database/sql 0.182s
ok database/sql/driver 0.020s
ok debug/dwarf 0.133s
ok debug/elf 0.228s
ok debug/goobj 0.019s
ok debug/gosym 0.020s
ok debug/macho 0.243s
ok debug/pe 0.227s
ok debug/plan9obj 0.079s
? encoding [no test files]
ok encoding/ascii85 0.023s
ok encoding/asn1 0.028s
ok encoding/base32 0.025s
ok encoding/base64 0.024s
ok encoding/binary 0.027s
ok encoding/csv 0.025s
ok encoding/gob 0.082s
ok encoding/hex 0.021s
ok encoding/json 0.281s
ok encoding/pem 0.024s
ok encoding/xml 0.043s
ok errors 0.024s
ok expvar 0.035s
ok flag 0.021s
ok fmt 0.089s
ok go/ast 0.034s
ok go/build 9.972s
ok go/doc 0.254s
ok go/format 0.031s
ok go/parser 0.062s
ok go/printer 0.927s
ok go/scanner 0.022s
ok go/token 0.061s
? hash [no test files]
ok hash/adler32 0.038s
ok hash/crc32 0.020s
ok hash/crc64 0.020s
ok hash/fnv 0.025s
ok html 0.022s
ok html/template 0.133s
ok image 0.924s
ok image/color 0.028s
? image/color/palette [no test files]
ok image/draw 0.151s
ok image/gif 0.227s
ok image/jpeg 0.431s
ok image/png 0.091s
ok index/suffixarray 0.029s
ok io 0.037s
ok io/ioutil 0.024s
ok log 0.029s
? log/syslog [no test files]
ok math 0.028s
ok math/big 0.540s
ok math/cmplx 0.022s
ok math/rand 0.572s
ok mime 0.027s
ok mime/multipart 1.552s
--- FAIL: TestResolveIPAddr (0.00 seconds)
ipraw_test.go:74: ResolveIPAddr(ip6:ipv6-icmp, ::1) failed: write
/net/cs: cs: no match
FAIL
FAIL net 0.944s
ok net/http 8.109s
ok net/http/cgi 0.137s
ok net/http/cookiejar 0.035s
ok net/http/fcgi 0.031s
ok net/http/httptest 0.061s
ok net/http/httputil 0.180s
? net/http/pprof [no test files]
ok net/mail 0.026s
ok net/rpc 0.187s
ok net/rpc/jsonrpc 0.036s
ok net/smtp 0.118s
ok net/textproto 0.024s
ok net/url 0.029s
ok os 3.994s
ok os/exec 0.390s
ok os/signal 0.017s
ok os/user 0.026s
ok path 0.027s
ok path/filepath 0.990s
ok reflect 0.188s
ok regexp 0.385s
ok regexp/syntax 1.361s
ok runtime 89.326s
ok runtime/debug 0.108s
ok runtime/pprof 0.989s
? runtime/race [no test files]
ok sort 0.145s
ok strconv 0.774s
ok strings 0.203s
ok sync 0.147s
ok sync/atomic 0.172s
ok syscall 0.021s
ok testing 2.887s
? testing/iotest [no test files]
ok testing/quick 0.071s
ok text/scanner 0.026s
ok text/tabwriter 0.025s
ok text/template 0.076s
ok text/template/parse 0.030s
ok time 4.077s
ok unicode 0.024s
ok unicode/utf16 0.023s
ok unicode/utf8 0.027s
? unsafe [no test files]
59.66u 17.04s 369.97r go test std -short -timeout ... # status= 1
all.rc 401: run.rc 1210: time 1216: go 1217: 1
============
go version devel +1afdecdd77c1 Sat Mar 29 17:10:25 2014 -0400 plan9/386
