Quoth [email protected]:
>
> More generally, wouldn't it be more clear to use PCI_VENDOR_ID, PCI_DEVICE_ID,
> etc. from a header instead of the hardcoded values? (that may be hard
> to grep to find if support is there or not---I missed at first that
> there is a U.S. Robotics card with a Realtek chip in the list since
> the vendor id is 0x16EC, to be compared with Realtek 0x10EC.)
>
> What do you, and what do other think about this?
It's far clearer, in my books, to have:
switch(did){
case 0x8169: /* Rtl8169 */
...
}
in the one place that it's used, than to have it hidden in
a header somewhere. All of our drivers are currently self
contained, and use this pattern. Let's not break that.
------------------------------------------
9fans: 9fans
Permalink:
https://9fans.topicbox.com/groups/9fans/T832e366730c74bfa-M45b2fce46acb2a1c83d73a14
Delivery options: https://9fans.topicbox.com/groups/9fans/subscription
