These were prompted by the factory change, but you're right, they're orthogonal.
Garrett Rooney wrote: > On 7/10/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> Author: jmsnell >> Date: Mon Jul 10 16:42:23 2006 >> New Revision: 420662 >> >> URL: http://svn.apache.org/viewvc?rev=420662&view=rev >> Log: >> Factory interface simplifications >> Removed most of the convenience methods that are already available via >> the other interfaces >> Simplified the alternatives impl > > There are a few changes in here that don't seem to be related to this... > > Specifically, > >> +++ >> incubator/abdera/java/trunk/parser/src/main/java/org/apache/abdera/parser/stax/FOMContent.java >> Mon Jul 10 16:42:23 2006 >> @@ -127,6 +127,10 @@ >> if (value != null) { >> if (this.getFirstElement() != null) >> this.getFirstElement().discard(); >> + if (value instanceof Div && !type.equals(Content.Type.XML)) >> + init(Content.Type.XHTML); >> + else >> + init(Content.Type.XML); >> this.setFirstChild((OMElement)value); >> } else { >> _removeAllChildren(); > > And this: > >> +++ >> incubator/abdera/java/trunk/parser/src/main/java/org/apache/abdera/parser/stax/FOMText.java >> Mon Jul 10 16:42:23 2006 >> @@ -106,6 +106,7 @@ >> if (value != null) { >> if (this.getFirstChildWithName(Constants.DIV) != null) >> this.getFirstChildWithName(Constants.DIV).discard(); >> + init(Text.Type.XHTML); >> this.setFirstChild((OMElement)value); >> } else >> _removeAllChildren(); > > It's really best to get into the habit of making each change do only > one thing, rather than mixing them together like this... > > -garrett >
