Ok. I can do it that way too, but I don't like it. :) I don't think
that matches the way the source tree is set up. If what the src
directory in the "dependencies" folder is going to produce is a
"json.jar", there should probably be another level in there:
"dependencies/json/src..." Otherwise, what will be done if you need
another src-tree-based dependency? I see that the Ant build is
building json.jar from only the src files in org/json. From that it
would appear the intention would be to build multiple jars from that
src tree. That really won't work well for Maven; the rule is one
artifact per source tree.
Another issue I guess I should ask about before I try to make another
patch is about how this json.jar should be referred to from a Maven
point-of-view. My patch made it:
org.apache.abdera:abdera-dependencies. Would it be better to
distribute under org.json:json-asl (and have the file name be
json-asl-${version}.jar )? I think we should be asking the JSON guys
before distributing it under their namespace in a Maven repository.
Finally, can we put a version number on it? Neither I nor Maven likes
unversioned jars.
- Stephen
On 7/15/06, James M Snell <[EMAIL PROTECTED]> wrote:
This doesn't appear to be quite right. If I'm interpreting the maven
stuff properly, this would build the json stuff into an
abdera-dependencies jar. The ant build builds it into a json.jar that's
included in the dist/lib directory. That's the way the maven build
should work also.
- James
Stephen Duncan wrote:
> Added a Maven build for the source-dependencies, and added a
> dependency on it in the extensions project to get JSON.
>
> [[[
> Include JSON dependency code in Maven build.
>
> * pom.xml: Added dependencies module to Maven build.
> * dependencies/pom.xml: Added Maven build for dependencies module.
> * dependencies: Added "target" directory to svn:ignore.
> * extensions/pom.xml: Added abdera-dependencies as a dependency.
> ]]]
>
>
> ------------------------------------------------------------------------
>
> Index: java/trunk/extensions/pom.xml
> ===================================================================
> --- java/trunk/extensions/pom.xml (revision 422259)
> +++ java/trunk/extensions/pom.xml (working copy)
> @@ -27,7 +27,13 @@
> <artifactId>abdera-parser</artifactId>
> <version>0.1.0-incubating-SNAPSHOT</version>
> <scope>compile</scope>
> - </dependency>
> + </dependency>
> + <dependency>
> + <groupId>org.apache.abdera</groupId>
> + <artifactId>abdera-dependencies</artifactId>
> + <version>0.1.0-incubating-SNAPSHOT</version>
> + <scope>compile</scope>
> + </dependency>
> <dependency>
> <groupId>ws-commons</groupId>
> <artifactId>axiom-api</artifactId>
>
> Property changes on: java\trunk\dependencies
> ___________________________________________________________________
> Name: svn:ignore
> -
> work
> .classpath
> .project
> *.jar
> bin
>
> +
> work
> .classpath
> .project
> *.jar
> bin
> target
>
>
> Index: java/trunk/dependencies/pom.xml
> ===================================================================
> --- java/trunk/dependencies/pom.xml (revision 0)
> +++ java/trunk/dependencies/pom.xml (revision 0)
> @@ -0,0 +1,18 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +<project
> + xmlns="http://maven.apache.org/POM/4.0.0";
> + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
> + <parent>
> + <groupId>org.apache.abdera</groupId>
> + <artifactId>abdera</artifactId>
> + <version>0.1.0-incubating-SNAPSHOT</version>
> + </parent>
> + <modelVersion>4.0.0</modelVersion>
> + <artifactId>abdera-dependencies</artifactId>
> + <packaging>jar</packaging>
> + <name>Abdera Dependencies</name>
> + <version>0.1.0-incubating-SNAPSHOT</version>
> + <description>Internal Abdera Dependencies that are not available
externally.</description>
> + <inceptionYear>2006</inceptionYear>
> +</project>
> Index: java/trunk/pom.xml
> ===================================================================
> --- java/trunk/pom.xml (revision 422259)
> +++ java/trunk/pom.xml (working copy)
> @@ -134,7 +134,8 @@
> </dependencies>
> </dependencyManagement>
>
> - <modules>
> + <modules>
> + <module>dependencies</module>
> <module>core</module>
> <module>parser</module>
> <module>security</module>
--
Stephen Duncan Jr
www.stephenduncanjr.com
