Argh ... hopefully, here are the two files that didn't make it
through the first time ...
sheepishly,
AC
On 26-Mar-07, at 9:14 PM, Adam Constabaris wrote:
On 26-Mar-07, at 12:46 AM, James M Snell wrote:
Excellent. Feel free to post the patch here or in jira and I'll
get it
applied.
- James
My patch-fu being weak (darned if I can figure out how to create a
complete patchset with svn diff in a timely fashion), I've
attached the following:
1. i18n.patch (root and core poms)
2. build.xml (dependencies/i18n/build.xml)
3. build.properties (dependencies/i18n/build.properties)
4. pom.xml (dependencies/i18n/pom.xml)
The way I approached it, it would probably make slightly more sense
to move the i18n directory up to be a submodule, so it could take
better advantage of maven inheritance. Also, a warning: I changed
the version to 0.3.0-incubating-SNAPSHOT, which is what both the
new POM and new build.xml create. There's no change to the master
build.xml, so the new build.xml is not invoked unless it's done
manually. I hope it's still useful =)
(additional conditional apologies in advance, since I'm using
Mail.App attachments for the first time)
cheers,
AC
<build.xml>
<pom.xml>
Adam Constabaris wrote:
This isn't directly related, but I do have a pom for the i18n
dependency, which also requires patching the pom for the core
subproject. If nobody's yet done a build.xml, I'll take a look at
generating one of those and submitting a patch.
cheers,
AC
On 24-Mar-07, at 3:19 PM, James M Snell wrote:
+1. that's been on my todo list. It wouldn't break my heart if
someone
else got to it first ;-)
- James
Garrett Rooney wrote:
So, if the i18n code is going to be separate from the rest of
Abdera
(i.e. we're planning on moving it out of the tree eventually)
would it
be possible to extract its build logic from build/build.xml? I
was
thinking of updating my work-in-progress ivy patch today, but I
don't
want to totally duplicate the current logic to build the i18n
stuff.
It seems like we could just put a stupidly-simple build.xml in
dependencies/i18n, and since we are trying to make that code
independent it's going to need that eventually anyway...
-garrett
