Yep. I've just made a change that the factories list is completely enclosed within ExtensionFactoryMap. All access to it is via methods on the map class. It will never be directly exposed to the FOMFactory. I've also wrapped the copied list using Collections.synchronizedList() and sync'd all iterations over it. That should be enough.
- James Garrett Rooney wrote: > On 4/25/07, James M Snell <[EMAIL PROTECTED]> wrote: >> Wait, I take that back... each Factory impl is already getting it's own >> copy of the Factories list. So long as we serialize access to it, I >> don't think it's going to be much of a problem. > > I'm not sure I follow here. Maybe this means the constructor doesn't > need to worry about copying the list, but it seems extremely unwise to > have the accessor method simply return a reference to it, as that > means the caller needs to know how to serialize on it in order to > safely do anything with it. > > -garrett >
