Cool. will watch for the patch.
- James
David Calavera wrote:
I've been working on it this afternoon. I've created a 'commons' package
into the adapters directory. I think it's a good place, so all adapter
inherited classes could be placed out of the server package. Does that
works?
I can submit the patch tomorrow, so you can see the directory structure.
On Thu, Feb 21, 2008 at 10:58 PM, James M Snell <[EMAIL PROTECTED]> wrote:
For now, can the commonalities be bundled up into a single common,
abstract, base JdbcAdapter class? If so, it could be included alongside
things like the BasicAdapter, etc in the Server module.
- James
David Calavera wrote:
Hi, I'm working on some test for IbatisCollectionAdapter and
HibernateCollectionAdapter and I'd like to do a big refactor.
Currently as much these tests as CouchDBCollectionAdapterTest have
almost
the same test methods with the same code lines. I think it could be
quite
easy to extract these methods to an other inherited class and just
maintain
the specific adapter configuration into the test class. My main doubt is
where can I put a class that all adapters can inherit? Can anyone help
me?
Regards
