[ https://issues.apache.org/jira/browse/ABDERA-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Calavera updated ABDERA-144: ---------------------------------- Attachment: debug_exceptions_minior_than_500.patch this patch log the responseContextExceptions with debug method if the status code is minior than 500, otherwhise the log shows a warning message. > Unecessary logging on DELETE on 404s > ------------------------------------ > > Key: ABDERA-144 > URL: https://issues.apache.org/jira/browse/ABDERA-144 > Project: Abdera > Issue Type: Improvement > Affects Versions: 0.4.0 > Reporter: Remy Gendron > Attachments: debug_exceptions_minior_than_500.patch > > > target: AbstractEntityCollectionAdapter.deleteEntry(String, RequestContext) > If the resource does not exist, throw new ResponseContextException(404) will > generate logging at the INFO level. The exception is not an error but used to > control program flow. As Dan says: > OK. I think the right fix is to: > 1. Log the ResponseContextExceptions at DEBUG if status code < 500. > (Could've sworn I did this before...) > 2. Fix the client side of it so it returns a SUCCESS on 404 and DELETE > But, James correctly says: > 404 is a client error as defined by RFC 2616. Defining it as a SUCCESS would > be a bug and would break existing code. For 404, > getType() should return CLIENT_ERROR and the client needs to check the status > code. > Thus, my initial report that SUCCESS should be returned was wrong. > Only the logging issue need be fixed. > Thanks. > Remy -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.